-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ds.dims returning dict #8500
Merged
dcherian
merged 26 commits into
pydata:main
from
TomNicholas:deprecate_ds_dims_returning_dict
Dec 6, 2023
Merged
Changes from 9 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
19708fa
raise FutureWarning
TomNicholas 9747fe7
change some internal instances of ds.dims -> ds.sizes
TomNicholas 0362233
improve clarity of which unexpected errors were raised
TomNicholas 99d7e16
whatsnew
TomNicholas 3e05777
return a class which warns if treated like a Mapping
TomNicholas 5a22dca
fix failing tests
TomNicholas 72eb62d
avoid some warnings in the docs
TomNicholas e911155
silence warning caused by #8491
TomNicholas 382601f
Merge branch 'main' into deprecate_ds_dims_returning_dict
TomNicholas 2c9cb7d
fix another warning
TomNicholas d862f89
typing of .get
TomNicholas 225414c
fix various uses of ds.dims in tests
TomNicholas 3391c83
fix some warnings
TomNicholas 93f8caa
add test that FutureWarnings are correctly raised
TomNicholas c0aa491
more fixes to avoid warnings
TomNicholas e4d45ac
update tests to avoid warnings
TomNicholas abc4a20
yet more fixes to avoid warnings
TomNicholas ef11e77
also warn in groupby.dims
TomNicholas 965673b
change groupby tests to match
TomNicholas 27f7642
update whatsnew to include groupby deprecation
TomNicholas 3406cc7
filter warning when we actually test ds.dims
TomNicholas 726f390
remove error I used for debugging
TomNicholas d1209ea
Merge branch 'main' into deprecate_ds_dims_returning_dict
TomNicholas 0b6466e
Merge branch 'main' into deprecate_ds_dims_returning_dict
TomNicholas b473d24
Merge branch 'main' into deprecate_ds_dims_returning_dict
TomNicholas ddbab72
Merge branch 'main' into deprecate_ds_dims_returning_dict
dcherian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clever!