Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: vendor SerializableLock from dask and use as default backend lock, adapt tests #8571

Merged
merged 7 commits into from
Jan 4, 2024
Merged

ENH: vendor SerializableLock from dask and use as default backend lock, adapt tests #8571

merged 7 commits into from
Jan 4, 2024

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Dec 22, 2023 •
edited
Loading

@kmuehlbauer
Copy link
Contributor Author

kmuehlbauer commented Dec 22, 2023 •
edited
Loading

Before moving forward here, I'd like to get feedback, if everything is OK with copying the code over from dask.

@kmuehlbauer kmuehlbauer marked this pull request as ready for review January 3, 2024 14:21
dcherian
dcherian reviewed Jan 3, 2024
View reviewed changes
doc/whats-new.rst Outdated Show resolved Hide resolved
@dcherian
Copy link
Contributor

dcherian commented Jan 3, 2024

Adding this lock might fix some of our xfails in test_backends.py. Mind taking a look at the windows ones?

@kmuehlbauer
Copy link
Contributor Author

@dcherian Yes, can have a look the coming days. I'll test first a bit on my windows box to not have to debug on CI.

@dcherian
Copy link
Contributor

dcherian commented Jan 3, 2024

In that case, let's merge and remove the xfails later!

@kmuehlbauer kmuehlbauer changed the title ENH: fork SerializableLock from dask and use as default backend lock, adapt tests ENH: vendor SerializableLock from dask and use as default backend lock, adapt tests Jan 3, 2024
@dcherian dcherian added the plan to merge Final call for comments label Jan 3, 2024
@kmuehlbauer kmuehlbauer merged commit 693f0b9 into pydata:main Jan 4, 2024
31 checks passed
@kmuehlbauer kmuehlbauer deleted the serializable-lock branch January 4, 2024 06:41
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 4, 2024
@dcherian
Merge remote-tracking branch 'upstream/main' into init-zarr
1498c35 
* upstream/main:
  Faster encoding functions. (pydata#8565)
  ENH: vendor SerializableLock from dask and use as default backend lock, adapt tests (pydata#8571)
  Silence a bunch of CachingFileManager warnings (pydata#8584)
  Bump actions/download-artifact from 3 to 4 (pydata#8556)
  Minimize duplication in `map_blocks` task graph (pydata#8412)
  [pre-commit.ci] pre-commit autoupdate (pydata#8578)
  ignore a `DeprecationWarning` emitted by `seaborn` (pydata#8576)
  Fix mypy type ignore (pydata#8564)
  Support for the new compression arguments. (pydata#7551)
  FIX: reverse index output of bottleneck move_argmax/move_argmin functions (pydata#8552)
kmuehlbauer added a commit to kmuehlbauer/xarray that referenced this pull request Jan 5, 2024
@kmuehlbauer
remove xfail in succession of pydata#8571
2246a34
@kmuehlbauer kmuehlbauer mentioned this pull request Jan 5, 2024
Merged
@snowman2 snowman2 mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman left review comments

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot pickle '_thread.lock' object exception after DataArray transpose and copy operations from netCDF file.
3 participants
@kmuehlbauer @dcherian @jhamman