Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI: temporary pin pytest version to 7.4.* #8682

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix CI: temporary pin pytest version to 7.4.* #8682

merged 1 commit into from
Jan 29, 2024

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 enabled auto-merge (squash) January 29, 2024 22:53
@max-sixty
Copy link
Collaborator

Thanks a lot!

@andersy005 andersy005 merged commit b0b5b2f into pydata:main Jan 29, 2024
27 of 28 checks passed
@andersy005 andersy005 deleted the fix-tests branch January 29, 2024 23:19
andersy005 added a commit to TomNicholas/xarray that referenced this pull request Jan 30, 2024
@andersy005
Merge branch 'main' into namedarray-parallelcompat
53906e4 
* main: (153 commits)
  Add overloads to get_axis_num (pydata#8547)
  Fix CI: temporary pin pytest version to 7.4.* (pydata#8682)
  Bump the actions group with 1 update (pydata#8678)
  [namedarray] split `.set_dims()` into `.expand_dims()` and `broadcast_to()` (pydata#8380)
  Add chunk-friendly code path to `encode_cf_datetime` and `encode_cf_timedelta` (pydata#8575)
  Fix NetCDF4 C version detection (pydata#8675)
  groupby: Don't set `method` by default on flox>=0.9 (pydata#8657)
  Fix automatic broadcasting when wrapping array api class (pydata#8669)
  Fix unstack method when wrapping array api class (pydata#8668)
  Fix `variables` arg typo in `Dataset.sortby()` docstring (pydata#8670)
  dt.weekday_name - removal of function (pydata#8664)
  Add `dev` dependencies to `pyproject.toml` (pydata#8661)
  CI: Pin scientific-python/upload-nightly-action to release sha (pydata#8662)
  Update HOW_TO_RELEASE.md by clarifying where RTD build can be found (pydata#8655)
  ruff: use extend-exclude (pydata#8649)
  new whats-new section (pydata#8652)
  xfail another test on windows (pydata#8648)
  use first element of residual in _nonpolyfit_1d (pydata#8647)
  whatsnew for v2024.01.1
  implement `isnull` using `full_like` instead of `zeros_like` (pydata#7395)
  ...
mgorny added a commit to mgorny/xarray that referenced this pull request Jan 31, 2024
@mgorny
Revert "Fix CI: temporary pin pytest version to 7.4.* (pydata#8682)"
fde7b4e 
This reverts commit b0b5b2f.
The tests should be fixed now.
dcherian pushed a commit that referenced this pull request Jan 31, 2024
@mgorny
Fixes for pytest-8.0.0 compatibility (#8686)
ca10531 
* test_dataset: remove incorrect pytest.warns() to fix pytest-8

Remove two incorrect `pytest.warns()` assertions to fix test failures
with pytest-8.0.0.  Prior to this version, an exception raised would
cause `pytest.warns()` to be ignored.  This way fixed in 8.0.0, and now
warnings must actually be emitted prior to the exception.

In `test_drop_index_labels()`, the exception is raised at the very
beginning of the function, prior to the deprecation warning.

In `test_rename_multiindex()`, the warning is not emitted at all (it is
not applicable to the call in question).

* test_groupby: Clear recorded warnings for pytest-8 compatibility

Clear the warnings recorded during the `pytest.warns()` use
in `test_groupby_dims_property`, to fix test failures with pytest-8.0.0.
Prior to this version, `pytest.warns()` invocation used to capture all
warnings.  Now it only captures the warnings that match the arguments,
and the remaining warnings are re-emitted and therefore caught by
`recwarn` fixture.  To provide compatibility with both versions of
pytest, clear the recorded warnings immediately after `pytest.warns()`.

Fixes #8681

* Revert "Fix CI: temporary pin pytest version to 7.4.* (#8682)"

This reverts commit b0b5b2f.
The tests should be fixed now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andersy005 @max-sixty