Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dt.date to plottable types #8873

Merged
merged 13 commits into from
Mar 29, 2024
Merged

Add dt.date to plottable types #8873

merged 13 commits into from
Mar 29, 2024

Conversation

saschahofmann
Copy link
Contributor

@saschahofmann saschahofmann commented Mar 25, 2024 •
edited
Loading

Simply adds datetime.date to plottable types in _ensure_plottable in plot/utils.pyL675 to enable the plotting of dates.

Matplotlib handles date types automatically, so I think there is no other change needed.

Do I need to add a test for this? Any pointers on where I would put it that?

@welcome Welcome
Copy link

welcome bot commented Mar 25, 2024

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@saschahofmann saschahofmann mentioned this pull request Mar 25, 2024
Closed
5 tasks
@Illviljan
Copy link
Contributor

Could you add a test in https://github.com/pydata/xarray/blob/main/xarray/tests/test_plot.py so we don't regress?

@saschahofmann
Copy link
Contributor Author

Sure! Shall I just check whether it plots ? Something like this test_datetime_dimension in L612 just with a date dimension?

@saschahofmann
Copy link
Contributor Author

I added the test_date_dimension plot, I saw that there is a whole TestDatetimePlot class. Should I add an equivalent or even refactor it so I only need to change the self.darray? Or is it fine with a single test?

@saschahofmann
Copy link
Contributor Author

saschahofmann commented Mar 28, 2024 •
edited
Loading

Quick question: Would it be worth it to un-gitignore your .vscode folder?

dcherian
dcherian approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks!

@dcherian dcherian added the plan to merge Final call for comments label Mar 28, 2024
@dcherian dcherian merged commit 852b7e6 into pydata:main Mar 29, 2024
33 checks passed
@welcome Welcome
Copy link

welcome bot commented Mar 29, 2024

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

dcherian added a commit to dcherian/xarray that referenced this pull request Apr 2, 2024
@dcherian
Merge branch 'main' into state-machine
4399d96 
* main: (26 commits)
  [pre-commit.ci] pre-commit autoupdate (pydata#8900)
  Bump the actions group with 1 update (pydata#8896)
  New empty whatsnew entry (pydata#8899)
  Update reference to 'Weighted quantile estimators' (pydata#8898)
  2024.03.0: Add whats-new (pydata#8891)
  Add typing to test_groupby.py (pydata#8890)
  Avoid in-place multiplication of a large value to an array with small integer dtype (pydata#8867)
  Check for aligned chunks when writing to existing variables (pydata#8459)
  Add dt.date to plottable types (pydata#8873)
  Optimize writes to existing Zarr stores. (pydata#8875)
  Allow multidimensional variable with same name as dim when constructing dataset via coords (pydata#8886)
  Don't allow overwriting indexes with region writes (pydata#8877)
  Migrate datatree.py module into xarray.core. (pydata#8789)
  warn and return bytes undecoded in case of UnicodeDecodeError in h5netcdf-backend (pydata#8874)
  groupby: Dispatch quantile to flox. (pydata#8720)
  Opt out of auto creating index variables (pydata#8711)
  Update docs on view / copies (pydata#8744)
  Handle .oindex and .vindex for the PandasMultiIndexingAdapter and PandasIndexingAdapter (pydata#8869)
  numpy 2.0 copy-keyword and trapz vs trapezoid (pydata#8865)
  upstream-dev CI: Fix interp and cumtrapz (pydata#8861)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments topic-plotting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot plot datetime.date dimension
3 participants
@saschahofmann @Illviljan @dcherian