-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete deprecation of Dataset.dims returning dict #8980
base: main
Are you sure you want to change the base?
Complete deprecation of Dataset.dims returning dict #8980
Conversation
Interestingly changing the return type of |
This feels a bit quick to me because this change had a pretty big blast radius. Shall we wait till September or so? |
Happy to wait. I just noticed that in the docstring for
Does that mean that returning a |
I think we've discussed it before and decided that the unordered nature of set was a good hint to users to not depend on the ordering for anything. |
Okay that's what I would want too. But that does mean that Dataset.transpose will not change Dataset.dims... It can at most change the dims of the Variables wrapped by that Dataset. |
This sounds fine to me. You can't rely on |
Tests addedwhats-new.rst
New functions/methods are listed inapi.rst