Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #9061

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jun 3, 2024

@dcherian dcherian enabled auto-merge (squash) June 3, 2024 19:41
@max-sixty
Copy link
Collaborator

#9062 doesn't seem to have worked.

Should we run all tests on all required PRs again? 😞

@mathause
Copy link
Collaborator

mathause commented Jun 3, 2024

I was also confused in #9020 (only doc changes) - I would know now...

@dcherian
Copy link
Contributor

dcherian commented Jun 3, 2024

Should we run all tests on all required PRs again? 😞

Yes I guess we should do that 😮‍💨

@max-sixty
Copy link
Collaborator

FYI to give you an idea of what's required for this sort of thing to work well, this is what we do in PRQL — it's quite the effort: https://github.com/PRQL/prql/blob/3bc10e9fd9202bb441869e56d340569f6e8cc146/.github/workflows/tests.yaml#L514-L587

@dcherian dcherian merged commit ccebef0 into main Jun 10, 2024
28 checks passed
@dcherian dcherian deleted the pre-commit-ci-update-config branch June 10, 2024 15:42
andersy005 pushed a commit that referenced this pull request Jun 14, 2024
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.3...v0.4.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants