add order for polynomial interpolation, fixes #8762 #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
for more information, see https://pre-commit.ci
…k/xarray into fix_polynomial_resample
dcherian
reviewed
Jun 10, 2024
|
Thanks a lot @nkarasiak this is a nice first PR. Can you update the test here please for xarray/xarray/tests/test_groupby.py Line 2055 in ef709df |
setdefault "bounds_error", and not forcing it. Thanks @dcherian Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
…k/xarray into fix_polynomial_resample
for more information, see https://pre-commit.ci
…k/xarray into fix_polynomial_resample
for more information, see https://pre-commit.ci
…k/xarray into fix_polynomial_resample
|
Tests and implementation are ok for me👍 |
dcherian
reviewed
Jun 10, 2024
dcherian
reviewed
Jun 10, 2024
|
Nice thanks @nkarasiak welcome to Xarray! |
for more information, see https://pre-commit.ci
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
andersy005
pushed a commit
that referenced
this pull request
Jun 14, 2024
* add order for polynomial, fixes #8762 * add bugfixes in whats_new.rst, fixes #8762 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo * Update xarray/core/resample.py setdefault "bounds_error", and not forcing it. Thanks @dcherian Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com> * chore(test) : polynomial resample * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(setdefault) : change dict to arg * fix(test) : polynomial interpolate tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * chore(test) : add comment using interp1d for polynomial * Update xarray/tests/test_groupby.py * Update doc/whats-new.rst * Update whats-new.rst * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rst