-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add note to docs on DataTree root-group naming conventions #9298
Conversation
… group name is always "/").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played with the generated doc strings but couldn't get them to work with the .. note::
pragma But have added what I would suggest and shown some output.
You can apply these suggestions and merge this or I can just pull these changes into the #9033.
Co-authored-by: Matt Savoie <github@flamingbear.com>
Co-authored-by: Matt Savoie <github@flamingbear.com>
Co-authored-by: Matt Savoie <github@flamingbear.com>
Co-authored-by: Matt Savoie <github@flamingbear.com>
Oh well, I've just applied the proposed changes. But do whatever suits best for your doc integration workflow. You might still pull everything you need from here. I can also squash everything into one commit, if that's easier. |
@kmuehlbauer I think this is fine to merge or close either way is fine with me. I grabbed the pieces you wrote trying to test it out. ec341ad But that may still take a while to get to main. I'll approve this for you in either case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the update.
OK, then let's merge it here to closeout #9293. |
root group name is always "/"
whats-new.rst