Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rechunking to a frequency with empty bins. #9364

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix rechunking to a frequency with empty bins. #9364

merged 1 commit into from
Aug 14, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian added topic-chunked-arrays Managing different chunked backends, e.g. dask plan to merge Final call for comments labels Aug 14, 2024
@dcherian dcherian mentioned this pull request Aug 14, 2024
Closed
5 tasks
spencerkclark
spencerkclark approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dcherian! I agree with this fix—sorry this scenario didn't occur to me in my previous review.

@dcherian
Copy link
Contributor Author

No worries, I forgot too!

@dcherian dcherian merged commit 68e86f4 into pydata:main Aug 14, 2024
40 checks passed
dcherian added a commit to dcherian/xarray that referenced this pull request Aug 14, 2024
@dcherian
Merge branch 'main' into groupby-shuffle
939db9a 
* main:
  Revise (pydata#9366)
  Fix rechunking to a frequency with empty bins. (pydata#9364)
  whats-new entry for dropping python 3.9 (pydata#9359)
  drop support for `python=3.9` (pydata#8937)
  Revise (pydata#9357)
  try to fix scheduled hypothesis test (pydata#9358)
@dcherian dcherian deleted the fix-frequency-rechunk branch August 16, 2024 02:55
dcherian added a commit to TomNicholas/xarray that referenced this pull request Aug 22, 2024
@dcherian
Merge branch 'main' into hypothesis-strategies
4994797 
* main: (214 commits)
  Adds copy parameter to __array__ for numpy 2.0 (pydata#9393)
  `numpy 2` compatibility in the `pydap` backend (pydata#9391)
  pyarrow dependency added to doc environment (pydata#9394)
  Extend padding functionalities (pydata#9353)
  refactor GroupBy internals (pydata#9389)
  Combine `UnsignedIntegerCoder` and `CFMaskCoder` (pydata#9274)
  passing missing parameters to ZarrStore.open_store when opening a datatree (pydata#9377)
  Fix tests on big-endian systems (pydata#9380)
  Improve error message on `ds['x', 'y']` (pydata#9375)
  Improve error message for missing coordinate index (pydata#9370)
  Add flaky to TestNetCDF4ViaDaskData (pydata#9373)
  Make chunk manager an option in `set_options` (pydata#9362)
  Revise (pydata#9371)
  Remove duplicate word from docs (pydata#9367)
  Adding open_groups to BackendEntryPointEngine, NetCDF4BackendEntrypoint, and H5netcdfBackendEntrypoint (pydata#9243)
  Revise (pydata#9366)
  Fix rechunking to a frequency with empty bins. (pydata#9364)
  whats-new entry for dropping python 3.9 (pydata#9359)
  drop support for `python=3.9` (pydata#8937)
  Revise (pydata#9357)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerkclark spencerkclark spencerkclark approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments topic-chunked-arrays Managing different chunked backends, e.g. dask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimeResampler("ME") can't deal with missing months
2 participants
@dcherian @spencerkclark