Don't return IndexVariable with .dt accessor #9415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
fix-dt-accessor-index-var
branch
from
9d60841 to
0d6967d
Compare
spencerkclark
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Thanks @dcherian—I agree, I don't think there is much of a need to preserve IndexVariable objects with the .dt accessor. Thanks for fixing the unstack issue too!
The mypy failure is maybe real?
4 tasks
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
* Don't return IndexVariable with .dt accessor Closes pydata#9190 * Support unstacking of index coordinates * Finish test * Fix mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable/IndexVariable#9190whats-new.rstapi.rstI think it makes sense to limit how much we expose IndexVariable to users so I removed it.
This PR also auto-converts IndexVariable to Variable when unstacking.