Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite interp to use
apply_ufunc
#9881Rewrite interp to use
apply_ufunc
#9881Changes from all commits
c1603c5
6109f6e
61c5b2c
81b73b9
652bcc1
03f0b36
9b915b2
be5c783
a5e1854
eef94fa
79a7e56
6e22072
8d4503a
586f638
972e9fb
38e66fc
43a0691
97a388e
ef24840
437219f
c152ca3
6c1dd95
1b9845d
81b8a90
6f6dd0a
e6ec62b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled by
vectorize=True
. This is possibly a perf regression with numpy arrays, but a massive improvement with chunked arrays.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity the bad thing about this approach is that it can greatly expand the number of core dimensions for the problem, limiting the potential for parallelism.
Consider the problem in #6799 (comment). In the following, dimension names are listed out in
[]
.da[time, q, lat, lon].interp(q=bar[lat,lon])
gets rewritten toda[time,q,lat,lon].interp(q=bar[lat, lon], lat=lat[lat], lon=lon[lon])
which thanks to our automatic rechunking, makes dask merge chunks inlat, lon
too, for no benefit.