-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix warning from scipy backend guess_can_open on directory #9911
fix warning from scipy backend guess_can_open on directory #9911
Conversation
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a useful addition, thanks!
Should we maybe catch a PermissionError as well?
And feel free to add an entry in whats-new.
When passing a directory to open_dataset(), the scipy backend fails and a "RuntimeWarning: 'scipy' fails while guessing" is produced. This affects me since I'm implementing a backend to read data written by the adios2 package, whose data "files" are actually a directory. This tiny patch treats this case just like file not found, that is, the scipy backend will now return that it cannot open such a "file", but without raising an exception.
4505e6f
to
133e3dd
Compare
I figured this change is too minor to justify a whats-new entry, but I'd be happy to do so if you'd like. Good point about considering |
You are right, a PermissionError should be raised normally here. You can still add an entry in what's new if you like. |
Thanks! |
When passing a directory to open_dataset(), the scipy backend fails and a "RuntimeWarning: 'scipy' fails while guessing" is produced.
This affects me since I'm implementing a backend to read data written by the adios2 package, whose data "files" are actually a directory.
This tiny patch treats this case just like file not found, that is, the scipy backend will now return that it cannot open such a "file", but without raising an exception.