Add activate/deactivate hooks #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
native-api
reviewed
Mar 19, 2023
|
@pyenv/pyenv-core-maintainers and especially @yyuu : any second opinions on the hook invocation placement? |
native-api
approved these changes
Mar 20, 2023
yyuu
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
looks good 👍
personally i might not apply very much of customization on activate/deactivate to keep shell setup cleaner/simpler, however, i can understand that there are some demands to customize the behavior around them. i’m open to adopt this definitely (esp. with working patch 😉 )
|
@joshfrench Thank you for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
activate/deactivatehooks have been discussed several times but I haven't seen a PR, so... here's one :)There are two test failures in
test/activateandtest/deactivatethat I think are just me not fully understanding the stub system, do you mind taking a look and pointing me in the right direction? Thanks so much!Past discussions: