Types enhancements for Cerberus 2 #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a more efficient validation, because the constraints are always given in the same expectable form. It also lays the ground mechanics for similar uses for other rules. Also, object lookups in the expansion code are reduced.
They are also stricter, so that values of a subtype are not matching.
funkyfuture
force-pushed
the
types_enhancements
branch
from
55729e3
to
ad75bfe
Compare
This is essential for a later implementation of dataclass instances.
funkyfuture
force-pushed
the
types_enhancements
branch
from
ad75bfe
to
ef09ff9
Compare
…around helpers in its typing module
funkyfuture
force-pushed
the
types_enhancements
branch
from
01740c0
to
ecd91fd
Compare
|
merged with 2a6e2b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this implements the proposals in #374 and adds a conversion of generic type aliases to constraints for the type rule that will be necessary to implement dataclass validation (#397). please see the changed docs for details on the features.
some notes on the pr:
TODOs regarding schema normalization that are not in the scope of types and shall be solved later