New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file handle not closed #32

Closed

chfw opened this issue May 6, 2017 · 0 comments

Member

chfw commented May 6, 2017

get_data function blurred the responsibility of the file handle management. Hence here is the fix:

get_data would always store data in memory and close the file handle
iget_data would defer the data reading and leave the file handle to the developer to close.

pyexcel/pyexcel-xlsx#14

chfw added a commit that referenced this issue


          addressing #32: clarify the responsibility of file handle

ab42854

chfw added a commit that referenced this issue


          explicitly close csv file handles #32

b0291e7

chfw closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment