Respect 'Factor in Reload' preference for sustainable tank (tidied up). #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
- Coverage 15.77% 15.76% -0.01%
==========================================
Files 2379 2379
Lines 34601 34622 +21
==========================================
Hits 5457 5457
- Misses 29144 29165 +21 |
|
Looks correct to me. If you don't mind, I'll be pinging you if we get issues popping up about the cap stuff, since I've always looked at it going @_@. But what are doing here makes sense. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the reported sustainable tank for AAR and ASB. Resolves #1439 when used with the new capsim.
I did this fix in eso/savedata/fit.py. You can do it in effects but that involves overwriting the peak (reinforced) repair figures which I think should be shown all the time as the actual peak. If extrattributes were put in to hold sustained values then you could do the fix in effects without any down side.
Anyway have a play and see if it breaks. Comment welcome.