Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix matplotlib deprecation #69

Merged
merged 4 commits into from
Jul 12, 2024
Merged

fix matplotlib deprecation #69

merged 4 commits into from
Jul 12, 2024

Conversation

ahms5
Copy link
Member

@ahms5 ahms5 commented Jun 27, 2024

  • test are failing atm
  • matplotlib.cm.COLORMAP is deprecated.
  • remove plt.show() in plot module, i was thinking this was the reson for the failing notebook
  • notebook is still failing, now idea why, maybe we just stick to older versions of matplotlib

@f-brinkmann
Copy link
Member

Maybe try the notebook locally with different versions of matplotlib and numpy? Might also be related to numpy 2.0 maybe

@ahms5 ahms5 mentioned this pull request Jun 28, 2024
Copy link
Member

@mberz mberz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@mberz mberz merged commit b0e33c0 into main Jul 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants