This repository has been archived by the owner on Aug 15, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
My intention is to support stringref spec for cbor. The basic idea of the spec is to reference duplicate strings instead of copying them many times. It has two tags:
As the spec says, this functionality must specifically be supported by encoder/decoder because you need to enumerate every non-tagged string in the right order to be able to refer to it later.
Currently, this PR implements a very minimal (and not fully compliant) decoder just to show the impact on the codebase of the crate. The functionality is entirely disabled (only empty vec is initialized) until the tag 256 appears so I believe it doesn't affect performance.
While currently this spec is not widely supported the tag numbers are reserved by IANA so will not conflict with anything. And I hope to promote and increase adoption of this spec by other implementations too.
What do you think? Will this functionality be accepted into serde_cbor?