tf32 vs fp32 fix #157
Merged
tf32 vs fp32 fix #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts not there anymore. this is an essential part of letting a user choose between tf32 and fp32. without it our internal CI fails w/ numerical issues, since the vanilla matmuls run in fp32 but grouped gemm incorrectly runs in tf32
for more information, see https://pre-commit.ci
rusty1s
approved these changes
Dec 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 22 22
Lines 671 671
=======================================
Hits 622 622
Misses 49 49 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally made this a part of my PR tf32 vs fp32 but somehow its not there anymore. this is an essential part of letting a user choose between tf32 and fp32. without it our internal CI fails w/ numerical issues, since the vanilla matmuls run in fp32 but grouped gemm incorrectly runs in tf32