Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random_walk implementation #21

Merged
merged 26 commits into from
Apr 26, 2022
Merged

random_walk implementation #21

merged 26 commits into from
Apr 26, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Apr 23, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #21 (fa3a48c) into master (a7f20d4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fa3a48c differs from pull request most recent head 5f1cd19. Consider uploading reports for the commit 5f1cd19 to get more accurate results

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         4    +3     
  Lines            5        32   +27     
=========================================
+ Hits             5        32   +27     
Impacted Files Coverage Δ
pyg_lib/csrc/sampler/cpu/random_walk_kernel.cpp 100.00% <100.00%> (ø)
pyg_lib/csrc/sampler/cpu/utils.h 100.00% <100.00%> (ø)
pyg_lib/csrc/sampler/random_walk.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f20d4...5f1cd19. Read the comment docs.

@rusty1s
Copy link
Member Author

rusty1s commented Apr 25, 2022

@yaoyaowd This is now ready to review. GPU implementation will follow in a separate PR.

@pyg-team pyg-team deleted a comment from ZenoTan Apr 25, 2022
@pyg-team pyg-team deleted a comment from ZenoTan Apr 25, 2022
@rusty1s rusty1s mentioned this pull request Apr 25, 2022
37 tasks
pyg_lib/sampler/__init__.py Show resolved Hide resolved
pyg_lib/csrc/sampler/cpu/utils.h Show resolved Hide resolved
pyg_lib/csrc/sampler/random_walk.cpp Show resolved Hide resolved
pyg_lib/csrc/sampler/cpu/random_walk_kernel.cpp Outdated Show resolved Hide resolved
pyg_lib/csrc/sampler/cpu/random_walk_kernel.cpp Outdated Show resolved Hide resolved
pyg_lib/csrc/sampler/cpu/random_walk_kernel.cpp Outdated Show resolved Hide resolved
pyg_lib/csrc/sampler/cpu/random_walk_kernel.cpp Outdated Show resolved Hide resolved
cmake/test.cmake Outdated Show resolved Hide resolved
@rusty1s
Copy link
Member Author

rusty1s commented Apr 26, 2022

All review comments have been addressed. Thank you very much for these.

@rusty1s rusty1s merged commit 897bd6d into master Apr 26, 2022
@rusty1s rusty1s deleted the random_walk branch April 26, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants