Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CXX_STANDARD to 17 to align with PyTorch master #231

Merged
merged 1 commit into from
May 24, 2023

Conversation

yanbing-j
Copy link
Contributor

PyTorch master has updated to CXX_STANDARD 17 since 5/19/2023. pyg-lib needs to update accordingly to avoid build failure.

@yanbing-j yanbing-j requested a review from rusty1s May 24, 2023 07:54
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #231 (423cfeb) into master (f1c3153) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files          28       28           
  Lines         883      883           
=======================================
  Hits          739      739           
  Misses        144      144           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s
Copy link
Member

rusty1s commented May 24, 2023

Thank you!

@rusty1s rusty1s merged commit 83ca492 into master May 24, 2023
@rusty1s rusty1s deleted the yanbing/update_C++17 branch May 24, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants