Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relabel_neighborhood and hetero_relabel_neighborhood functions #254

Merged
merged 7 commits into from
Sep 15, 2023

Conversation

kgajdamo
Copy link
Contributor

@kgajdamo kgajdamo commented Sep 6, 2023

This code belongs to the part of the whole distributed training for PyG.

This PR is complementary to the #246.

##Descrption
Perform global to local mappings using mapper and create (row, col) based on a sampled_nodes_with_duplicates and sampled_nbrs_per_node.

Other distributed PRs:
pytorch_geometric DistLoader: #7869
pytorch_geometric DistSampler: #7974
pyg-lib [MERGED]: #246
pyg-lib: #252
pyg-lib: #253

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #254 (0607d72) into master (3bf8802) will increase coverage by 0.96%.
The diff coverage is 98.50%.

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   84.30%   85.26%   +0.96%     
==========================================
  Files          30       32       +2     
  Lines        1026     1093      +67     
==========================================
+ Hits          865      932      +67     
  Misses        161      161              
Files Changed Coverage Δ
pyg_lib/csrc/sampler/cpu/dist_relabel_kernel.cpp 97.36% <97.36%> (ø)
pyg_lib/csrc/sampler/dist_relabel.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s enabled auto-merge (squash) September 15, 2023 13:43
@rusty1s rusty1s merged commit e12b30c into pyg-team:master Sep 15, 2023
10 checks passed
@kgajdamo
Copy link
Contributor Author

@rusty1s Thank you for the review. I a question regarding the init.py file. I noticed you removed declarations of my functions from this file and now we cannot call them from Python. Do you have any other idea for this?

@kgajdamo
Copy link
Contributor Author

@rusty1s Thank you for the review. I a question regarding the init.py file. I noticed you removed declarations of my functions from this file and now we cannot call them from Python. Do you have any other idea for this?

@rusty1s It works. Never mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants