Benchmark scripts and pyg::sampler::Mapper
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 99.48% 97.27% -2.22%
==========================================
Files 9 10 +1
Lines 195 220 +25
==========================================
+ Hits 194 214 +20
- Misses 1 6 +5
Continue to review full report at Codecov.
|
rusty1s
changed the title
pyg::Mapperpyg::sampler::Mapper
|
Could you put some benchmark numbers here? Thanks. |
|
ZenoTan
reviewed
May 6, 2022
ZenoTan
approved these changes
May 11, 2022
yaoyaowd
reviewed
May 11, 2022
| auto deg_data = deg.data_ptr<scalar_t>(); | ||
| auto grain_size = at::internal::GRAIN_SIZE; | ||
| at::parallel_for(0, nodes.size(0), grain_size, [&](int64_t _s, int64_t _e) { | ||
| for (scalar_t i = _s; i < _e; ++i) { | ||
| for (size_t i = _s; i < _e; ++i) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought
pyg::sampler::Mapperis a clever way to re-use mapping functionality across several samplers. In addition, I noticed that the usage ofstd::unordered_mapslows downsubgraphcreation by a significant factor, so I use a simple heuristic to determine if its usage is actually advantageous.