-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autograd for segment_matmul
#61
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this perfect. A test would be great to ensure correctness.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
the last CI failure seems unrelated to my changes. |
also unsure how to integrate the python test I wrote as part of this PR into the CI for this project |
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 90.68% 83.89% -6.80%
==========================================
Files 13 13
Lines 247 267 +20
==========================================
Hits 224 224
- Misses 23 43 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @puririshi98. I made some further changes. Also testing autograd on the CPP-level now. I am in favor of merging this but ultimately there is a backward pass missing to compute other_grad
. I don't think we can implement this via segment_matmul
- it probably needs its own implementation. Let's sync later on this.
No description provided.