Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SparseTensor label in LightGCN #5046

Merged
merged 9 commits into from
Jul 30, 2022
Merged

Support SparseTensor label in LightGCN #5046

merged 9 commits into from
Jul 30, 2022

Conversation

hzg0601
Copy link
Contributor

@hzg0601 hzg0601 commented Jul 25, 2022

fix the bug of models/lightgcn when edge_indx is an instance of SparseTensor in forward method

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #5046 (f87a57f) into master (25ff6d9) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #5046      +/-   ##
==========================================
- Coverage   83.00%   82.99%   -0.01%     
==========================================
  Files         332      332              
  Lines       18336    18339       +3     
==========================================
+ Hits        15219    15220       +1     
- Misses       3117     3119       +2     
Impacted Files Coverage Δ
torch_geometric/nn/models/lightgcn.py 96.20% <25.00%> (-2.49%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rusty1s rusty1s changed the title fix the bug of models/lightgcn when edge_indx is an instance of Spars… Support SparseTensor label in LightGCN Jul 25, 2022
torch_geometric/nn/models/lightgcn.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/lightgcn.py Outdated Show resolved Hide resolved
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s enabled auto-merge (squash) July 30, 2022 17:49
@rusty1s rusty1s merged commit 1d89adf into pyg-team:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

models/lightgcn raises an error when the edge_index is an instance of SparseTensor in forward method
2 participants