Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SparseTensor label in LightGCN #5046

Merged
merged 9 commits into from
Jul 30, 2022
Merged

Support SparseTensor label in LightGCN #5046

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ad83c15
fix the bug of models/lightgcn when edge_indx is an instance of Spars…
hzg0601 Jul 25, 2022
3b6a886
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2022
e55299f
Update CHANGELOG.md
hzg0601 Jul 25, 2022
01f5691
Update torch_geometric/nn/models/lightgcn.py
hzg0601 Jul 25, 2022
eef74d0
Update CHANGELOG.md
hzg0601 Jul 25, 2022
34e7d2d
Update lightgcn.py
hzg0601 Jul 25, 2022
0f763ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2022
a8fdb99
update
rusty1s Jul 30, 2022
f87a57f
Merge branch 'master' into models-lightgcn
rusty1s Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,5 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed subclass behaviour of `process` and `download` in `Datsaet` ([#4586](https://github.com/pyg-team/pytorch_geometric/pull/4586))
- Fixed filtering of attributes for loaders in case `__cat_dim__ != 0` ([#4629](https://github.com/pyg-team/pytorch_geometric/pull/4629))
- Fixed `torch.fx` bug with `torch.nn.aggr` package ([#5021](https://github.com/pyg-team/pytorch_geometric/pull/5021)))
- Support SparseTensor label in LightGCN(#[5046](https://github.com/pyg-team/pytorch_geometric/issues/5046))
### Removed
10 changes: 9 additions & 1 deletion torch_geometric/nn/models/lightgcn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from torch import Tensor
from torch.nn import Embedding, ModuleList
from torch.nn.modules.loss import _Loss
from torch_sparse import SparseTensor

from torch_geometric.nn.conv import LGConv
from torch_geometric.typing import Adj, OptTensor
Expand Down Expand Up @@ -110,7 +111,14 @@ def forward(self, edge_index: Adj,
:obj:`edge_index` will be used instead. (default: :obj:`None`)
"""
if edge_label_index is None:
edge_label_index = edge_index
if isinstance(edge_index, SparseTensor):
edge_label_index = torch.stack(edge_index.coo()[:2], dim=0)

elif isinstance(edge_index, torch.Tensor):

edge_label_index = edge_index
else:
raise TypeError

out = self.get_embedding(edge_index)

Expand Down