Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make batch argument optionnal in voxel_grid / update GridSampling documentation #3533

Merged
merged 5 commits into from
Nov 19, 2021

Conversation

QuanticDisaster
Copy link
Contributor

This PR does the following :

  • adds documentation on return nature of GridSampling
  • removes the mandatory argument 'batch' for voxel_grid, defaulting it to None

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #3533 (a1416f5) into master (ceba827) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3533   +/-   ##
=======================================
  Coverage   81.83%   81.84%           
=======================================
  Files         292      292           
  Lines       14574    14576    +2     
=======================================
+ Hits        11927    11929    +2     
  Misses       2647     2647           
Impacted Files Coverage Δ
torch_geometric/nn/pool/voxel_grid.py 100.00% <100.00%> (ø)
torch_geometric/transforms/grid_sampling.py 96.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceba827...a1416f5. Read the comment docs.

@rusty1s
Copy link
Member

rusty1s commented Nov 19, 2021

This is great. Thank you!

@rusty1s rusty1s merged commit f693d7c into pyg-team:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants