Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quiver-team] Add Quiver example for multi-gpu training using GraphSage #4103

Merged
merged 19 commits into from
Feb 23, 2022

Conversation

eedalong
Copy link
Contributor

@eedalong eedalong commented Feb 21, 2022

[quiver-team] Add Quiver example for multi-gpu training using GraphSage.

@eedalong eedalong changed the title Add Quiver example for multi-gpu training using GraphSage [quiver-team] Add Quiver example for multi-gpu training using GraphSage Feb 21, 2022
@luomai
Copy link
Contributor

luomai commented Feb 21, 2022

Hi PyG team,

This is the PR to contribute PyG examples with GPU-based sampling + feature aggregation on a GPU and multiple GPUs through Quiver. We observe substantial speed up in the PyG examples with GraphSage.

We will create another PR for distributed sampling + feature aggregation in 2 - 3 weeks. We have been testing the performance of distributed sampling in the last few weeks, and the code will be ready soon.

Quiver team.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great. Thanks for the efforts. It might be also a good idea to link to this example from the README.md. WDYT?

examples/multi_gpu/distributed_sampling_quiver.py Outdated Show resolved Hide resolved
@luomai
Copy link
Contributor

luomai commented Feb 22, 2022

I think this looks great. Thanks for the efforts. It might be also a good idea to link to this example from the README.md. WDYT?

@rusty1s Yes, this a good idea! Where shall we put this link? Maybe under the "Implemented GNN models"?

@eedalong
Copy link
Contributor Author

I think this pr is ready to merge, what you guys think? @luomai @rusty1s

@rusty1s
Copy link
Member

rusty1s commented Feb 23, 2022

Thank you very much! This is great.

@rusty1s rusty1s merged commit 2c45c98 into pyg-team:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants