-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py
: Make more requirements optional
#4133
Conversation
As the community for |
Thanks for the PR. I'm happy to move some of these dependencies to optional ones. We would need to add a new CI test to ensure that PyG can still successfully run even when dropping these dependencies. Furthermore, I wonder what are the security concerns of these packages? These are all pretty popular packages. |
Sure, I know of this tool https://snyk.io/advisor/python being used to check the health of different packages and in the case of |
@adelizer I added a GitHub action to test a minimal installation (currently checks if imports work as expected). As the test fails, we need to make the dependencies truly optional before we can merge this PR. |
setup.py
: Make more requirements optional
All issues are now resolved. Thank you for the PR! |
@rusty1s Thanks a lot!! Any proposed date for the next release with this change included? |
Next release is scheduled around mid March. Let me know if this is early enough for you. |
If there is an option for an earlier one that would be greatly helpful! |
Do you need to install from PyPi or does installing via GitHub work as well?
AFAIK, PyTorch 1.11 is coming soon, and we would like to wait for it before releasing any new version. |
Great, thanks for explaining! I will wait for mid March then since it is not possible to install directly from GitHub. As in our use case all packages are mirrored on an internal PyPI |
Hey @adelizer, can you reach out to me on |
Moving the following packages to
full_install_requires
:yacs
hydra-core
class-resolver>=0.3.2
googledrivedownloader
Keeping only essential packages in
install_requires
will enabletorch-geometric
to be installed in secure environments with strict package management constraints.