Fixed avg_deg calculation
#4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #4312 +/- ##
=======================================
Coverage 82.28% 82.29%
=======================================
Files 310 310
Lines 15877 15879 +2
=======================================
+ Hits 13065 13067 +2
Misses 2812 2812
Continue to review full report at Codecov.
|
rusty1s
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed calculation of
self.avg_deginpna_conv.pyto correctly calculate averages (the change is consistent with original code at https://github.com/lukecavabarrett/pna).The variable
degis a histogram of in-degrees of nodes in the training set. In the original implementation, the average degree is calculated by taking the mean of the elements ofdeg(the log and exp averages are calculated similarly). This actually takes an average of the frequencies, which is not the desired behaviour.This change ensures that
self.avg_degis indeed finding the average (and log and exp averages) of the vertex in-degrees by calculating the sum-product of the degrees and their associated frequencies.