Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove negative_sampling assert #4383

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Remove negative_sampling assert #4383

merged 1 commit into from
Mar 31, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Mar 31, 2022

No description provided.

@rusty1s rusty1s self-assigned this Mar 31, 2022
@rusty1s rusty1s linked an issue Mar 31, 2022 that may be closed by this pull request
In negative_sampling, assert captures an exception condition #4382
Closed
@rusty1s rusty1s mentioned this pull request Mar 31, 2022
Closed
@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #4383 (457dd34) into master (291f182) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4383      +/-   ##
==========================================
- Coverage   82.53%   82.53%   -0.01%     
==========================================
  Files         309      309              
  Lines       16017    16018       +1     
==========================================
  Hits        13220    13220              
- Misses       2797     2798       +1
Impacted Files Coverage Δ
torch_geometric/utils/negative_sampling.py 91.97% <50.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291f182...457dd34. Read the comment docs.

@rusty1s rusty1s merged commit 5d5aac7 into master Mar 31, 2022
@rusty1s rusty1s deleted the remove_neg_sample_assert branch March 31, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In negative_sampling, assert captures an exception condition
1 participant
@rusty1s