Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch Ignite example #4487

Merged
merged 23 commits into from
May 23, 2022
Merged

PyTorch Ignite example #4487

merged 23 commits into from
May 23, 2022

Conversation

scarpma
Copy link
Contributor

@scarpma scarpma commented Apr 16, 2022

@rusty1s I created the pull request connected to issue #4454 . This is my example. We can work together to adjust the content, the style and the amount of comments. For now it includes a lot of things. Maybe tensorboard logging could be removed in order to make it more simple.

Let me know if you like it.

And thanks for the explanation about how to make the pull request.

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #4487 (ed99f7a) into master (02fa0e5) will not change coverage.
The diff coverage is n/a.

❗ Current head ed99f7a differs from pull request most recent head 10f25f3. Consider uploading reports for the commit 10f25f3 to get more accurate results

@@           Coverage Diff           @@
##           master    #4487   +/-   ##
=======================================
  Coverage   82.98%   82.98%           
=======================================
  Files         319      319           
  Lines       16968    16968           
=======================================
  Hits        14081    14081           
  Misses       2887     2887           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fa0e5...10f25f3. Read the comment docs.

Copy link
Contributor Author

@scarpma scarpma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only added some comments. Don't know how to procede.

examples/pytorch_ignite/gin.py Show resolved Hide resolved
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
examples/pytorch_ignite/gin.py Show resolved Hide resolved
examples/pytorch_ignite/gin.py Show resolved Hide resolved
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
scarpma and others added 2 commits April 20, 2022 17:18
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
examples/pytorch_ignite/gin.py Outdated Show resolved Hide resolved
examples/pytorch_ignite/gin.py Show resolved Hide resolved
@scarpma
Copy link
Contributor Author

scarpma commented Apr 29, 2022

Any news on this ?

@rusty1s
Copy link
Member

rusty1s commented Apr 29, 2022

Will try to merge in the upcoming week. Sorry for the delay!

@scarpma
Copy link
Contributor Author

scarpma commented Apr 29, 2022

Will try to merge in the upcoming week. Sorry for the delay!

Ok perfect, don't worry. I was just checking in the case this was forgotten.

@rusty1s
Copy link
Member

rusty1s commented May 20, 2022

Sorry again for the delay. I currently do not have access to a GPU and still want to run it before merging.

@scarpma
Copy link
Contributor Author

scarpma commented May 20, 2022 via email

@rusty1s rusty1s changed the title add an example of pytorch ignite training with console and tensorboar… PyTorch Ignite example May 23, 2022
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s merged commit 5a6e826 into pyg-team:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants