Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test labels in LinkNeighborLoader #4508

Merged
merged 8 commits into from
Apr 22, 2022

Conversation

Padarn
Copy link
Contributor

@Padarn Padarn commented Apr 21, 2022

Fixing a small bug in the return type of the labels and and adding a test.

@Padarn Padarn self-assigned this Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #4508 (7a67685) into master (6a2b047) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4508      +/-   ##
==========================================
+ Coverage   82.69%   82.71%   +0.01%     
==========================================
  Files         313      313              
  Lines       16341    16341              
==========================================
+ Hits        13514    13517       +3     
+ Misses       2827     2824       -3     
Impacted Files Coverage Δ
torch_geometric/loader/link_neighbor_loader.py 93.12% <ø> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2b047...7a67685. Read the comment docs.

@Padarn
Copy link
Contributor Author

Padarn commented Apr 21, 2022

Faling test here looks irrelevant - flaky test?

@Padarn Padarn changed the title Fix label types in LinkNeighborLoader Test labels in LinkNeighborLoader Apr 21, 2022
torch_geometric/loader/link_neighbor_loader.py Outdated Show resolved Hide resolved
torch_geometric/loader/link_neighbor_loader.py Outdated Show resolved Hide resolved
@rusty1s rusty1s merged commit e65b295 into pyg-team:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants