Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change dataset behaviour when dataset is overridden #4586

Merged
merged 4 commits into from
May 4, 2022

Conversation

Padarn
Copy link
Contributor

@Padarn Padarn commented May 3, 2022

PR to address #4567

Changes in the behavior of how 'download' and 'process' are resolved by Dataset. Prior to this change, the functions needed to be defined in the child class, after this change they only need to be implemented in some class that is not the base Dataset.

@Padarn
Copy link
Contributor Author

Padarn commented May 3, 2022

Hey @rusty1s what is your intended interaction with CHANGELOG.md? Do you want all merges to master to add one, or only larger changes?

@rusty1s
Copy link
Member

rusty1s commented May 3, 2022

Every PR should at least change the CHANGELOG.md for now (either by writing a new line or adding the PR link to a larger feature).

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #4586 (f0ff396) into master (be97c5b) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4586      +/-   ##
==========================================
- Coverage   82.90%   82.78%   -0.12%     
==========================================
  Files         315      315              
  Lines       16592    16588       -4     
==========================================
- Hits        13756    13733      -23     
- Misses       2836     2855      +19     
Impacted Files Coverage Δ
torch_geometric/data/in_memory_dataset.py 77.27% <ø> (-0.67%) ⬇️
torch_geometric/data/dataset.py 96.80% <100.00%> (-0.80%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/io/tu.py 93.58% <0.00%> (-2.57%) ⬇️
torch_geometric/nn/models/mlp.py 98.41% <0.00%> (-1.59%) ⬇️
torch_geometric/transforms/gdc.py 78.17% <0.00%> (-1.02%) ⬇️
torch_geometric/nn/conv/rgat_conv.py 83.76% <0.00%> (-0.53%) ⬇️
torch_geometric/graphgym/utils/comp_budget.py 15.51% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be97c5b...f0ff396. Read the comment docs.

@Padarn Padarn self-assigned this May 4, 2022
@Padarn Padarn added the dataset label May 4, 2022
@rusty1s rusty1s merged commit 5ed4b38 into pyg-team:master May 4, 2022
pgmikhael added a commit to pgmikhael/pytorch_geometric that referenced this pull request Sep 16, 2022
Noticed the problem described in issue pyg-team#4567 (closed) and saw the proposed fix. The fix (pyg-team#4586) doesn't check whether download or process exist, which the previous implementation does. Perhaps this change is closer to the intended behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download and process methods are not called when Dataset is subclassed indirectly
2 participants