-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change dataset behaviour when dataset is overridden #4586
change dataset behaviour when dataset is overridden #4586
Conversation
Hey @rusty1s what is your intended interaction with |
Every PR should at least change the |
Codecov Report
@@ Coverage Diff @@
## master #4586 +/- ##
==========================================
- Coverage 82.90% 82.78% -0.12%
==========================================
Files 315 315
Lines 16592 16588 -4
==========================================
- Hits 13756 13733 -23
- Misses 2836 2855 +19
Continue to review full report at Codecov.
|
Noticed the problem described in issue pyg-team#4567 (closed) and saw the proposed fix. The fix (pyg-team#4586) doesn't check whether download or process exist, which the previous implementation does. Perhaps this change is closer to the intended behavior.
PR to address #4567
Changes in the behavior of how 'download' and 'process' are resolved by Dataset. Prior to this change, the functions needed to be defined in the child class, after this change they only need to be implemented in some class that is not the base
Dataset
.