-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check on add_self_loops
in HeteroConv
and to_hetero
#4647
Conversation
add_self_loops
in HeteroConv
and to_hetero
add_self_loops
in HeteroConv
and to_hetero
A number of tests fail now with the new check. I'm going to change these. Let me know if you think this should just be a warning so we don't break old code? |
Codecov Report
@@ Coverage Diff @@
## master #4647 +/- ##
=======================================
Coverage 82.96% 82.97%
=======================================
Files 316 316
Lines 16774 16782 +8
=======================================
+ Hits 13917 13925 +8
Misses 2857 2857
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I removed the check in to_hetero_with_bases
. Adding self-loops is actually allowed there since we are operating on a typed homogeneous graph.
Ah got it! Cheers for explaining.
…On Sun, 15 May 2022, 10:44 pm Matthias Fey, ***@***.***> wrote:
***@***.**** approved this pull request.
Thank you! I removed the check in to_hetero_with_bases since there,
adding self-loops is actually allowed since we are operating on a typed
homogeneous graph.
—
Reply to this email directly, view it on GitHub
<#4647 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRPN4UNRXHLH6KYGF6DP3VKEESBANCNFSM5V6WMITQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
By communicating with Grab Inc and/or its subsidiaries, associate
companies and jointly controlled entities (“Grab Group”), you are deemed to
have consented to the processing of your personal data as set out in the
Privacy Notice which can be viewed at https://grab.com/privacy/
<https://grab.com/privacy/>
This email contains confidential information
and is only for the intended recipient(s). If you are not the intended
recipient(s), please do not disseminate, distribute or copy this email
Please notify Grab Group immediately if you have received this by mistake
and delete this email from your system. Email transmission cannot be
guaranteed to be secure or error-free as any information therein could be
intercepted, corrupted, lost, destroyed, delayed or incomplete, or contain
viruses. Grab Group do not accept liability for any errors or omissions in
the contents of this email arises as a result of email transmission. All
intellectual property rights in this email and attachments therein shall
remain vested in Grab Group, unless otherwise provided by law.
|
Addresses #4646 to add a check on the convention
add_self_loops
argument.