Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support normalization_resolver in BasicGNN #4958

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Conversation

lightaime
Copy link
Contributor

This PR added support for normalization_resolver in basic_gnn.

@lightaime lightaime requested review from rusty1s and Padarn July 11, 2022 13:38
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #4958 (e6a5d4a) into master (5ce04c5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e6a5d4a differs from pull request most recent head 71aebac. Consider uploading reports for the commit 71aebac to get more accurate results

@@            Coverage Diff             @@
##           master    #4958      +/-   ##
==========================================
- Coverage   82.73%   82.72%   -0.01%     
==========================================
  Files         330      330              
  Lines       17904    17905       +1     
==========================================
  Hits        14812    14812              
- Misses       3092     3093       +1     
Impacted Files Coverage Δ
torch_geometric/nn/models/mlp.py 98.61% <ø> (ø)
torch_geometric/nn/models/basic_gnn.py 91.50% <100.00%> (+0.08%) ⬆️
torch_geometric/graphgym/config_store.py 78.61% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce04c5...71aebac. Read the comment docs.

@rusty1s rusty1s changed the title Support normalization_resolver in basic_gnn Support normalization_resolver in BasicGNN Jul 12, 2022
@rusty1s rusty1s merged commit bac7021 into master Jul 12, 2022
@rusty1s rusty1s deleted the resolve_norm_basicgnn branch July 12, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants