Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphStore: handle zero-sized edge indices #4962

Merged
merged 4 commits into from
Jul 12, 2022
Merged

GraphStore: handle zero-sized edge indices #4962

merged 4 commits into from
Jul 12, 2022

Conversation

mananshah99
Copy link
Contributor

Small fix for edge indices of shape (2, 0) (decomposed into two tensors of size 0), for which we cannot index into each tensor.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #4962 (fb16068) into master (6f62e53) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head fb16068 differs from pull request most recent head 6a70ab6. Consider uploading reports for the commit 6a70ab6 to get more accurate results

@@            Coverage Diff             @@
##           master    #4962      +/-   ##
==========================================
- Coverage   82.73%   82.73%   -0.01%     
==========================================
  Files         330      330              
  Lines       17901    17905       +4     
==========================================
+ Hits        14810    14813       +3     
- Misses       3091     3092       +1     
Impacted Files Coverage Δ
torch_geometric/data/graph_store.py 92.54% <75.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f62e53...6a70ab6. Read the comment docs.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s merged commit 5ce04c5 into master Jul 12, 2022
@rusty1s rusty1s deleted the put_edge_index branch July 12, 2022 06:36
@rusty1s rusty1s added the data label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants