Move GraphMultisetTransformer to nn.aggr package

[Padarn]

Addresses #4712

[Padarn]

Hey guys this one pulled up a small issue (maybe there is a simple fix I don't see).

The GraphMultisetTransformer imports GCNConv which is part of the nn.conv package.. but the nn.aggr package is also imported by the nn.conv package in MessagPassing.

Fixes I could think of

1. move GraphMultisetTransformer into nn.conv
2. move MessagPassing into its own package

Any other ideas? Given how GraphMultisetTransformer works (it has optional edge_index) I'm not very sure where it best lives.

WDYT @lightaime @rusty1s

[rusty1s]

@Padarn You should be able to import nn.conv.GCNConv inside GraphMultisetTransformer.__init__

[Padarn]

Well, turns out there is a simple solution that I was missing 😅. Thanks

…

On Thu, 14 Jul 2022, 12:09 am Matthias Fey, ***@***.***> wrote: @Padarn <https://github.com/Padarn> You should be able to import nn.conv.GCNConv inside GraphMultisetTransformer.__init__ — Reply to this email directly, view it on GitHub <#4973 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRPN3BB4AW53QM3WMNANTVT3S3JANCNFSM53MZ3SEQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- By communicating with Grab Inc and/or its subsidiaries, associate companies and jointly controlled entities (“Grab Group”), you are deemed to have consented to the processing of your personal data as set out in the Privacy Notice which can be viewed at https://grab.com/privacy/ <https://grab.com/privacy/> This email contains confidential information and is only for the intended recipient(s). If you are not the intended recipient(s), please do not disseminate, distribute or copy this email Please notify Grab Group immediately if you have received this by mistake and delete this email from your system. Email transmission cannot be guaranteed to be secure or error-free as any information therein could be intercepted, corrupted, lost, destroyed, delayed or incomplete, or contain viruses. Grab Group do not accept liability for any errors or omissions in the contents of this email arises as a result of email transmission. All intellectual property rights in this email and attachments therein shall remain vested in Grab Group, unless otherwise provided by law.

[codecov]

Codecov Report

Merging #4973 (6c15ce1) into master (a7224df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4973   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files         330      330           
  Lines       17970    17973    +3     
=======================================
+ Hits        14876    14879    +3     
  Misses       3094     3094           

Impacted Files	Coverage Δ
torch_geometric/nn/aggr/__init__.py	100.00% <100.00%> (ø)
torch_geometric/nn/aggr/base.py	93.61% <100.00%> (ø)
torch_geometric/nn/aggr/gmt.py	100.00% <100.00%> (ø)
torch_geometric/nn/glob/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7224df...6c15ce1. Read the comment docs.

[lightaime]

Thanks! LGTM!