Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SortAggr to SortAggregation #5085

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

Padarn
Copy link
Contributor

@Padarn Padarn commented Jul 29, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #5085 (9a9bd0d) into master (412ae53) will decrease coverage by 1.89%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #5085      +/-   ##
==========================================
- Coverage   84.86%   82.97%   -1.90%     
==========================================
  Files         332      332              
  Lines       18304    18300       -4     
==========================================
- Hits        15534    15184     -350     
- Misses       2770     3116     +346     
Impacted Files Coverage Δ
torch_geometric/nn/glob.py 81.25% <0.00%> (ø)
torch_geometric/nn/aggr/__init__.py 100.00% <100.00%> (ø)
torch_geometric/nn/aggr/sort.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/profile/profile.py 32.94% <0.00%> (-15.30%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/nn/resolver.py 88.00% <0.00%> (-6.00%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Padarn Padarn merged commit 3950ff6 into pyg-team:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants