Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: properly filter custom feature/graph stores #5088

Merged
merged 8 commits into from
Jul 30, 2022
Merged

Conversation

mananshah99
Copy link
Contributor

The current method of filtering relied on the buggy str_to_edge_type, which would fail if a node type had __ in its name.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #5088 (7949386) into master (2a16256) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7949386 differs from pull request most recent head 7458051. Consider uploading reports for the commit 7458051 to get more accurate results

@@           Coverage Diff           @@
##           master    #5088   +/-   ##
=======================================
  Coverage   83.00%   83.00%           
=======================================
  Files         333      333           
  Lines       18368    18369    +1     
=======================================
+ Hits        15246    15247    +1     
  Misses       3122     3122           
Impacted Files Coverage Δ
torch_geometric/loader/link_neighbor_loader.py 91.61% <100.00%> (ø)
torch_geometric/loader/neighbor_loader.py 94.93% <100.00%> (ø)
torch_geometric/loader/utils.py 81.57% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rusty1s rusty1s enabled auto-merge (squash) July 30, 2022 21:04
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rusty1s rusty1s added the data label Jul 30, 2022
@rusty1s rusty1s merged commit 58df978 into master Jul 30, 2022
@rusty1s rusty1s deleted the fix_filter_edge_store branch July 30, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants