Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for input module in GINEConv #5154

Merged
merged 9 commits into from
Aug 8, 2022
Merged

Fix bug for input module in GINEConv #5154

merged 9 commits into from
Aug 8, 2022

Conversation

Padarn
Copy link
Contributor

@Padarn Padarn commented Aug 7, 2022

See #5143

@Padarn Padarn self-assigned this Aug 7, 2022
@codecov
Copy link

codecov bot commented Aug 7, 2022 •
edited
Loading

Codecov Report

Merging #5154 (21020b2) into master (afd12c2) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #5154      +/-   ##
==========================================
- Coverage   82.98%   82.98%   -0.01%     
==========================================
  Files         333      333              
  Lines       18362    18365       +3     
==========================================
+ Hits        15238    15240       +2     
- Misses       3124     3125       +1
Impacted Files Coverage Δ
torch_geometric/nn/conv/gin_conv.py 97.33% <71.42%> (-1.28%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

rusty1s
rusty1s approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

torch_geometric/nn/conv/gin_conv.py Outdated Show resolved Hide resolved
@rusty1s rusty1s linked an issue Aug 7, 2022 that may be closed by this pull request
GINEConv assumes nn is subscriptable #5143
Closed
@Padarn Padarn merged commit 4433455 into pyg-team:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@Padarn Padarn

Labels
0 - Priority P0 bug nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GINEConv assumes nn is subscriptable
2 participants
@Padarn @rusty1s