Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightningLinkData: Support edge_label_time #5173

Merged
merged 40 commits into from
Aug 10, 2022

Conversation

wsad1
Copy link
Member

@wsad1 wsad1 commented Aug 9, 2022

LightningLinkData passes the edge_label_time to LinkNeighborLoader.
Needs #5137 to be merged.

wsad1 and others added 30 commits August 4, 2022 16:35
Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>
Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #5173 (58773cd) into master (5ad9f3c) will decrease coverage by 0.04%.
The diff coverage is 32.14%.

❗ Current head 58773cd differs from pull request most recent head e70abee. Consider uploading reports for the commit e70abee to get more accurate results

@@            Coverage Diff             @@
##           master    #5173      +/-   ##
==========================================
- Coverage   83.04%   82.99%   -0.05%     
==========================================
  Files         333      333              
  Lines       18403    18415      +12     
==========================================
+ Hits        15282    15283       +1     
- Misses       3121     3132      +11     
Impacted Files Coverage Δ
torch_geometric/data/lightning_datamodule.py 31.97% <20.83%> (-1.78%) ⬇️
torch_geometric/loader/link_neighbor_loader.py 93.08% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wsad1 wsad1 requested a review from rusty1s August 9, 2022 11:04
@rusty1s rusty1s marked this pull request as ready for review August 10, 2022 12:09
@rusty1s rusty1s changed the title LightningLinkData: Support edge_label_time. LightningLinkData: Support edge_label_time Aug 10, 2022
@rusty1s rusty1s enabled auto-merge (squash) August 10, 2022 13:39
@rusty1s rusty1s merged commit c7ef923 into pyg-team:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants