Tutorial on nn.aggr package
#5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5191 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 335 335
Lines 18485 18485
=======================================
Hits 15353 15353
Misses 3132 3132
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Padarn
approved these changes
Aug 12, 2022
docs/source/modules/nn.rst
Outdated
|
|
||
| output = mean_aggr(x, index) # Output shape: [100, 64] | ||
|
|
||
| Notably, all aggregations share the same set of forward arguments, as described in detail in :meth:`torch_geometric.nn.aggr.Aggregation.forward`. |
There was a problem hiding this comment.
Do we want to caveat here that there is not yet support for these arguments across all aggregations?
There was a problem hiding this comment.
Good point. I think we should do this in the doc-strings of the individual modules, using a warning box for example. Let me know if you want to add this in.
mananshah99
reviewed
Aug 12, 2022
Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>
Co-authored-by: Manan Shah <manan.shah.777@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.