Allow any integer tensors when checking edge_index input to message passing #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5281 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 337 337
Lines 18634 18635 +1
=======================================
+ Hits 15528 15529 +1
Misses 3106 3106
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
Aug 26, 2022
hatemhelal
force-pushed
the
message-passing-ints
branch
from
47e6dd1 to
12b198c
Compare
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #5087
This relaxes the
__check_input__method of the message passing interface to allow any integer types for theedge_index. This is necessary to allow PyTorch to dispatch to different execution backends (see this tutorial).This effectively defers the question of which types are supported to the underlying device backend.