Add Aggregation.set_validate_args method to toggle validation of dim_size
#5290
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5290 +/- ##
==========================================
- Coverage 85.27% 83.33% -1.95%
==========================================
Files 337 337
Lines 18639 18641 +2
==========================================
- Hits 15895 15535 -360
- Misses 2744 3106 +362
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
Aug 29, 2022
This was referenced Nov 30, 2022
rusty1s
added a commit
that referenced
this pull request
Dec 7, 2022
This patch removes `Aggregation.set_validate_args` that was added in #5290 and instead defers the checking of the index values when an exception is thrown by the aggregation. This works in both the standard eager-PyTorch mode as well in a compiled context. Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #5289
This change should default to running the eager validation but allows a user to override this behaviour when using different PyTorch execution backend.