-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IndexToMask
and MaskToIndex
transforms
#5375
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5375 +/- ##
==========================================
+ Coverage 83.39% 83.45% +0.05%
==========================================
Files 347 348 +1
Lines 18849 18907 +58
==========================================
+ Hits 15720 15778 +58
Misses 3129 3129
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
55e80fc
to
b6b6b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good, thank you! Left some nitpicky comments. One thing I would like to add is HeteroData
support. If this is too much to handle, we can add it in a follow-up PR.
Hey @hatemhelal. Can you give me write access to your fork/your PR? |
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
1efaaf9
to
6feff63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Both of these transforms will try to infer the right attributes to convert.
MaskToIndex
matches any attributes that end with_mask
IndexToMask
matches any attributes that end with_indices
.For the latter case, it would be a problem to automatically convert
edge_index
so I went with this suffix.