Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown label support in to_homogeneous #5540

Merged
merged 22 commits into from
Sep 30, 2022
Merged

Unknown label support in to_homogeneous #5540

merged 22 commits into from
Sep 30, 2022

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Sep 26, 2022 •
edited
Loading 

>>> x=torch_geometric.datasets.FakeHeteroDataset().data
>>> x.to_homogeneous().y
tensor([ 7.,  0.,  8.,  ..., -1., -1., -1.])
>>> x.to_homogeneous()
Data(edge_index=[2, 71136], y=[3497], node_type=[3497], edge_type=[71136])

@puririshi98 puririshi98 requested a review from rusty1s September 26, 2022 19:56
@github-actions github-actions bot added the data label Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022 •
edited
Loading

Codecov Report

Merging #5540 (5a2695b) into master (9fd349d) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 5a2695b differs from pull request most recent head 754220f. Consider uploading reports for the commit 754220f to get more accurate results

@@            Coverage Diff             @@
##           master    #5540      +/-   ##
==========================================
+ Coverage   83.68%   83.80%   +0.12%     
==========================================
  Files         346      346              
  Lines       19026    19010      -16     
==========================================
+ Hits        15922    15932      +10     
+ Misses       3104     3078      -26
Impacted Files Coverage Δ
torch_geometric/data/hetero_data.py 95.63% <100.00%> (+0.13%) ⬆️
torch_geometric/nn/norm/batch_norm.py 100.00% <0.00%> (ø)
torch_geometric/sampler/hgt_sampler.py 100.00% <0.00%> (ø)
torch_geometric/loader/link_neighbor_loader.py 100.00% <0.00%> (ø)
torch_geometric/nn/dense/linear.py 83.96% <0.00%> (+0.51%) ⬆️
torch_geometric/sampler/neighbor_sampler.py 92.90% <0.00%> (+1.02%) ⬆️
torch_geometric/loader/link_loader.py 94.02% <0.00%> (+1.49%) ⬆️
torch_geometric/data/collate.py 96.55% <0.00%> (+4.82%) ⬆️
torch_geometric/sampler/base.py 96.77% <0.00%> (+5.86%) ⬆️
torch_geometric/sampler/utils.py 97.01% <0.00%> (+16.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rusty1s
rusty1s reviewed Sep 27, 2022
View reviewed changes
torch_geometric/data/hetero_data.py Outdated Show resolved Hide resolved
torch_geometric/data/hetero_data.py Outdated Show resolved Hide resolved
torch_geometric/data/hetero_data.py Outdated Show resolved Hide resolved
torch_geometric/data/hetero_data.py Outdated Show resolved Hide resolved
torch_geometric/data/hetero_data.py Outdated Show resolved Hide resolved
@rusty1s rusty1s changed the title Labels for to_homogeneous Unknown label support in to_homogeneous Sep 27, 2022
@rusty1s rusty1s enabled auto-merge (squash) September 30, 2022 07:08
@rusty1s rusty1s merged commit 7fb1eb6 into master Sep 30, 2022
@rusty1s rusty1s deleted the labels_for_to_homo branch September 30, 2022 07:10
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@puririshi98 @pre-commit-ci
@Padarn @rusty1s @JakubPietrakIntel
Unknown label support in to_homogeneous (pyg-team#5540)
dc6a45b 
* Update hetero_data.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update hetero_data.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update hetero_data.py

* Update torch_geometric/data/hetero_data.py

Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>

* Update hetero_data.py

* Update hetero_data.py

* test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update hetero_data.py

* Update test_hetero_data.py

* Update test_hetero_data.py

* Update test_hetero_data.py

* Update test_hetero_data.py

* Update test_hetero_data.py

* Update test_hetero_data.py

* update

* update

* update

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>
Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Padarn Padarn Padarn left review comments

@rusty1s rusty1s rusty1s approved these changes

Assignees

@puririshi98 puririshi98

Labels
0 - Priority P0 data feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puririshi98 @Padarn @rusty1s