Add basic augmentation methods #5548

EdisonLeeeee · 2022-09-27T09:29:11Z

This PR added some basic augmentation methods for graphs:

NodeShuffle: randomly permute node ids
MaskFeature: randomly mask feature columns
AddEdge: randomly add edges into graphs

~~TODO~~:

~~add doc-string~~
~~add test~~

Link to #5452

codecov · 2022-09-27T16:08:39Z

Codecov Report

Merging #5548 (7312eb1) into master (4a9a494) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7312eb1 differs from pull request most recent head 50c9c0a. Consider uploading reports for the commit 50c9c0a to get more accurate results

@@            Coverage Diff             @@
##           master    #5548      +/-   ##
==========================================
- Coverage   83.77%   83.75%   -0.02%     
==========================================
  Files         346      347       +1     
  Lines       19070    19125      +55     
==========================================
+ Hits        15975    16019      +44     
- Misses       3095     3106      +11

Impacted Files	Coverage Δ
torch_geometric/utils/augmentation.py	`100.00% <100.00%> (ø)`
torch_geometric/sampler/utils.py	`80.51% <0.00%> (-7.18%)`	⬇️
torch_geometric/sampler/neighbor_sampler.py	`91.87% <0.00%> (-1.92%)`	⬇️
torch_geometric/loader/link_loader.py	`92.53% <0.00%> (-1.50%)`	⬇️
torch_geometric/nn/aggr/multi.py	`100.00% <0.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

wsad1

Looks good mostly. Left some initial comments.

torch_geometric/utils/augmentation.py

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

for more information, see https://pre-commit.ci

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

wsad1

Thanks a lot.

torch_geometric/utils/augmentation.py

test/utils/test_augmentation.py

torch_geometric/utils/augmentation.py

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

EdisonLeeeee · 2022-09-29T14:00:25Z

Thank you @wsad1 for your feedback. Really helpful!

torch_geometric/utils/augmentation.py

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

wsad1 · 2022-09-30T14:18:58Z

Yeah it would be nice to mention it there.

wsad1 · 2022-10-01T05:39:58Z

I don't think the failing tests are not related to this PR. Sorry about that. Will fix them soon.

lightaime

Awesome. Like it! Leave some minor comments.

torch_geometric/utils/augmentation.py

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

torch_geometric/utils/augmentation.py

Co-authored-by: Guohao Li <lightaime@gmail.com>

for more information, see https://pre-commit.ci

torch_geometric/utils/augmentation.py

test/utils/test_augmentation.py

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

* add basic augmentation methods * doc-string * test * raises * Update torch_geometric/utils/augmentation.py Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com> * Update torch_geometric/utils/augmentation.py Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update torch_geometric/utils/augmentation.py Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com> * fix * Update torch_geometric/utils/augmentation.py Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com> * Update test/utils/test_augmentation.py Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com> * Update torch_geometric/utils/augmentation.py Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * update * update test * changelog * update mask_feature * README * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * update * Update torch_geometric/utils/augmentation.py Co-authored-by: Guohao Li <lightaime@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * test * add fill_value * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * Update torch_geometric/utils/augmentation.py Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * update * fix test Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> Co-authored-by: Guohao Li <lightaime@gmail.com>

add basic augmentation methods

453d6a4

EdisonLeeeee added feature 1 - Priority P1 transform labels Sep 27, 2022

EdisonLeeeee self-assigned this Sep 27, 2022

github-actions bot removed the transform label Sep 27, 2022

EdisonLeeeee added 3 commits September 27, 2022 23:44

doc-string

74a8bc5

test

a3efee9

raises

47406fe

wsad1 reviewed Sep 29, 2022

View reviewed changes

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

EdisonLeeeee and others added 5 commits September 29, 2022 21:28

Update torch_geometric/utils/augmentation.py

4b4e1b3

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

Update torch_geometric/utils/augmentation.py

04b69ad

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

d3c8ae2

for more information, see https://pre-commit.ci

Update torch_geometric/utils/augmentation.py

49f8869

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

fix

6f8a170

wsad1 approved these changes Sep 29, 2022

View reviewed changes

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

test/utils/test_augmentation.py Outdated Show resolved Hide resolved

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

EdisonLeeeee and others added 3 commits September 29, 2022 21:59

Update torch_geometric/utils/augmentation.py

3d46b69

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

Update test/utils/test_augmentation.py

856c29c

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

Update torch_geometric/utils/augmentation.py

e64535f

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

rusty1s added the transform label Sep 29, 2022

rusty1s reviewed Sep 29, 2022

View reviewed changes

EdisonLeeeee and others added 2 commits September 30, 2022 09:48

Update torch_geometric/utils/augmentation.py

4293403

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

Update torch_geometric/utils/augmentation.py

fb73a7d

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

github-actions bot removed the transform label Sep 30, 2022

EdisonLeeeee and others added 4 commits September 30, 2022 09:50

Update torch_geometric/utils/augmentation.py

62998fd

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

Update torch_geometric/utils/augmentation.py

8f8a176

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

Update torch_geometric/utils/augmentation.py

9a9fed4

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

Update torch_geometric/utils/augmentation.py

8288370

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

EdisonLeeeee and others added 2 commits September 30, 2022 22:59

README

7312eb1

Merge branch 'master' into basic_aug

a6220bd

wsad1 enabled auto-merge (squash) October 1, 2022 05:29

wsad1 disabled auto-merge October 1, 2022 05:32

lightaime reviewed Oct 1, 2022

View reviewed changes

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

torch_geometric/utils/augmentation.py Show resolved Hide resolved

rusty1s reviewed Oct 1, 2022

View reviewed changes

EdisonLeeeee and others added 3 commits October 2, 2022 13:09

Update torch_geometric/utils/augmentation.py

618159e

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

Update torch_geometric/utils/augmentation.py

6e35825

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

Update torch_geometric/utils/augmentation.py

37a2d30

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

github-actions bot added the utils label Oct 2, 2022

update

c4ec9af

lightaime reviewed Oct 2, 2022

View reviewed changes

torch_geometric/utils/augmentation.py Outdated Show resolved Hide resolved

EdisonLeeeee and others added 5 commits October 3, 2022 22:18

Update torch_geometric/utils/augmentation.py

c8f6624

Co-authored-by: Guohao Li <lightaime@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

844963e

for more information, see https://pre-commit.ci

test

e9505ef

add fill_value

1d6b604

Merge branch 'master' into basic_aug

a19f57f

EdisonLeeeee requested review from rusty1s and lightaime October 4, 2022 03:05

rusty1s reviewed Oct 4, 2022

View reviewed changes

rusty1s and others added 5 commits October 4, 2022 06:41

Merge branch 'master' into basic_aug

404c5cf

Update torch_geometric/utils/augmentation.py

0f163df

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

Update torch_geometric/utils/augmentation.py

c67ee20

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

update

f3488f1

fix test

50c9c0a

rusty1s merged commit 947d71e into master Oct 5, 2022

rusty1s deleted the basic_aug branch October 5, 2022 01:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic augmentation methods #5548

Add basic augmentation methods #5548

EdisonLeeeee commented Sep 27, 2022 •

edited

Loading

codecov bot commented Sep 27, 2022 •

edited

Loading

wsad1 left a comment

wsad1 left a comment

EdisonLeeeee commented Sep 29, 2022

wsad1 commented Sep 30, 2022

wsad1 commented Oct 1, 2022 •

edited

Loading

lightaime left a comment

Add basic augmentation methods #5548

Add basic augmentation methods #5548

Conversation

EdisonLeeeee commented Sep 27, 2022 • edited Loading

codecov bot commented Sep 27, 2022 • edited Loading

Codecov Report

wsad1 left a comment

Choose a reason for hiding this comment

wsad1 left a comment

Choose a reason for hiding this comment

EdisonLeeeee commented Sep 29, 2022

wsad1 commented Sep 30, 2022

wsad1 commented Oct 1, 2022 • edited Loading

lightaime left a comment

Choose a reason for hiding this comment

EdisonLeeeee commented Sep 27, 2022 •

edited

Loading

codecov bot commented Sep 27, 2022 •

edited

Loading

wsad1 commented Oct 1, 2022 •

edited

Loading