Support in_channels with tuple in GENConv for bipartite message passing
#5627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5627 +/- ##
==========================================
- Coverage 83.87% 83.87% -0.01%
==========================================
Files 349 349
Lines 19196 19207 +11
==========================================
+ Hits 16101 16109 +8
- Misses 3095 3098 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
Oct 7, 2022
torch_geometric/nn/conv/gen_conv.py
Outdated
| channels.append(out_channels) | ||
| self.mlp = MLP(channels, norm=norm) | ||
|
|
||
| self.msg_norm = MessageNorm(learn_msg_scale) if msg_norm else None | ||
| if in_channels[0] != in_channels[1]: |
There was a problem hiding this comment.
Good point! Updated.
Sure. Will update it later. |
JakubPietrakIntel
pushed a commit
to JakubPietrakIntel/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
… passing (pyg-team#5627) * changelog * Support in_channels with tuple for bipartite message passing * changelog * update Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> * support lazy init * Added test Co-authored-by: Guohao Li <lighaime@gmail.com> Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports passing
in_channelswithtupletoGENConvfor bipartite message passing by projecting channels to the same dimension if channels mismatch.