Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GENConv linear layers for lazy init and fix doc for bipartite graphs #5641

Merged
merged 18 commits into from
Oct 11, 2022

Conversation

lightaime
Copy link
Contributor

@lightaime lightaime commented Oct 9, 2022

This PR fixes the linear layers for lazy init and doc of GENConv for bipartite graphs.

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #5641 (8cca4f1) into master (a6b92fd) will decrease coverage by 0.03%.
The diff coverage is 73.17%.

@@            Coverage Diff             @@
##           master    #5641      +/-   ##
==========================================
- Coverage   83.87%   83.84%   -0.04%     
==========================================
  Files         349      349              
  Lines       19213    19231      +18     
==========================================
+ Hits        16115    16124       +9     
- Misses       3098     3107       +9     
Impacted Files Coverage Δ
torch_geometric/nn/conv/gen_conv.py 78.00% <73.17%> (-6.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lightaime lightaime changed the title Fix GENConv doc for bipartite graphs Fix GENConv linear layers and doc for bipartite graphs Oct 9, 2022
@lightaime lightaime changed the title Fix GENConv linear layers and doc for bipartite graphs Fix GENConv linear layers for lazy init and doc for bipartite graphs Oct 9, 2022
@lightaime lightaime changed the title Fix GENConv linear layers for lazy init and doc for bipartite graphs Refactor GENConv linear layers for lazy init and doc for bipartite graphs Oct 9, 2022
@lightaime lightaime changed the title Refactor GENConv linear layers for lazy init and doc for bipartite graphs Refactor GENConv linear layers for lazy init and fix doc for bipartite graphs Oct 9, 2022
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. left some minor comments.

torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
@lightaime lightaime requested a review from rusty1s October 11, 2022 11:50
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is pretty cool.

test/nn/conv/test_gen_conv.py Outdated Show resolved Hide resolved
test/nn/conv/test_gen_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/gen_conv.py Outdated Show resolved Hide resolved
lightaime and others added 4 commits October 11, 2022 16:11
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
@lightaime lightaime merged commit 3733006 into master Oct 11, 2022
@lightaime lightaime deleted the fix_gen_doc branch October 11, 2022 14:24
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
…ite graphs (pyg-team#5641)

* changelog

* fix gen doc

* changelog

* update

* Refactor linear layers

* add test

* Fix edge linear layer

* update

* update

* update

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

* update

Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>

* update

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

* update

Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>

* update

Co-authored-by: Guohao Li <lighaime@gmail.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants